Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Code Reviews

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Post History

75%
+4 −0
Code Reviews JSON log formatter

I'd suggest using Black to format the code. While there are a number of formatters, it helps to pick one to make the code consistent. (See https://github.com/psf/black) The use of .update({"excep...

posted 1y ago by SLott56‭

Answer
#1: Initial revision by user avatar SLott56‭ · 2023-05-05T00:19:06Z (over 1 year ago)
I'd suggest using Black to format the code. While there are a number of formatters, it helps to pick one to make the code consistent.  (See https://github.com/psf/black)

The use of `.update({"exception": ...})` to insert a single item into a dictionary seems a bit of avoidable overhead. 

The name `log_record_dict` -- with a kind of type name at the end -- is something often called "Hungarian Notation". (https://en.wikipedia.org/wiki/Hungarian_notation) This is something that is often avoided in Python programming.