Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Code Reviews

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Post History

66%
+4 −1
Code Reviews Parsing numbers from a text file

You don't need a regex for this. To find first you can simply iterate through the line until you find a digit. To find second you can do the same but in reverse. This is more efficient than running...

posted 4mo ago by matthewsnyder‭  ·  edited 4mo ago by matthewsnyder‭

Answer
#3: Post edited by user avatar matthewsnyder‭ · 2024-07-18T21:14:33Z (4 months ago)
  • You don't need a regex for this. To find `first` you can simply iterate through the line until you find a digit. To find `second` you do the same but in reverse. This is more efficient than running a regex.
  • For a problem as small as the example, it doesn't matter and arguably the regex adds readability. But I assume AoC makes you run this on a much bigger input as well.
  • You also don't need to construct the calibration number as a string. `first*10 + second` gives the calibration number.
  • When finding the digits, you can do a time-space tradeoff by creating a hashmap that maps each char 0-9 to the corresponding digit. Plugging the chars into this map is probably faster than parsing the string to an integer.
  • You don't need a regex for this. To find `first` you can simply iterate through the line until you find a digit. To find `second` you can do the same but in reverse. This is more efficient than running a regex.
  • For a problem as small as the example, it doesn't matter and arguably the regex adds readability. But I assume AoC makes you run this on a much bigger input as well.
  • You also don't need to construct the calibration number as a string. `first*10 + second` gives the calibration number.
  • When finding the digits, you can do a time-space tradeoff by creating a hashmap that maps each char 0-9 to the corresponding digit. Plugging the chars into this map is probably faster than parsing the string to an integer.
#2: Post edited by user avatar matthewsnyder‭ · 2024-07-18T21:14:19Z (4 months ago)
  • You don't need a regex for this. To find `first` you simply iterate through the line until you find a digit. To find `second` you do the same but in reverse. This is more efficient than running a regex.
  • For a problem as small as the example, it doesn't matter and arguably the regex adds readability. But I assume AoC makes you run this on a much bigger input as well.
  • You also don't need to construct the calibration number as a string. `first*10 + second` gives the calibration number.
  • When finding the digits, you can do a time-space tradeoff by creating a hashmap that maps each char 0-9 to the corresponding digit. Plugging the chars into this map is probably faster than parsing the string to an integer.
  • You don't need a regex for this. To find `first` you can simply iterate through the line until you find a digit. To find `second` you do the same but in reverse. This is more efficient than running a regex.
  • For a problem as small as the example, it doesn't matter and arguably the regex adds readability. But I assume AoC makes you run this on a much bigger input as well.
  • You also don't need to construct the calibration number as a string. `first*10 + second` gives the calibration number.
  • When finding the digits, you can do a time-space tradeoff by creating a hashmap that maps each char 0-9 to the corresponding digit. Plugging the chars into this map is probably faster than parsing the string to an integer.
#1: Initial revision by user avatar matthewsnyder‭ · 2024-07-17T06:10:56Z (4 months ago)
You don't need a regex for this. To find `first` you simply iterate through the line until you find a digit. To find `second` you do the same but in reverse. This is more efficient than running a regex.

For a problem as small as the example, it doesn't matter and arguably the regex adds readability. But I assume AoC makes you run this on a much bigger input as well.

You also don't need to construct the calibration number as a string. `first*10 + second` gives the calibration number.

When finding the digits, you can do a time-space tradeoff by creating a hashmap that maps each char 0-9 to the corresponding digit. Plugging the chars into this map is probably faster than parsing the string to an integer.