Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Review Suggested Edit

You can't approve or reject suggested edits because you haven't yet earned the Edit Posts ability.

You're getting close, just need a few adjustments.
Instead of using the `hostname` property, I prefer to use `host`, because it also includes the port (in case the URL has one) - check the [documentation](https://developer.mozilla.org/en-US/docs/Web/API/Location/host) for more info.
You should also get the `protocol` (which can be `http`, `https`, etc), to build the full URL. Without it, you might not get what you want: suppose the current page is `https://software.codidact.com/posts/286256`. If I run this code:
```javascript
let domain = window.location.host;
window.location.href = domain + '?abc=1';
```
The result will be the URL `https://software.codidact.com/posts/software.codidact.com?abc=1`. Only by including the protocol at the beggining (before the `domain`), I get the correct URL (`https://software.codidact.com/?abc=1`).
~~To set the URL you should use `=`, not `===` (read [here](https://software.codidact.com/posts/282893) to know the difference).~~
Not sure how you're using the `h1` element, I guess you wanted to get its text? I included an example below, that gets the `innerText` property, which contains whatever text is inside the `h1` tag.
And finally, when the `shiftKey` property is set, the corresponding key will be uppercased, so instead of checking for `e`, you actually should check for `E`.
The final code:
```javascript
let domain = window.location.host;
let protocol = window.location.protocol;
let h1 = document.getElementsByTagName("h1");
window.addEventListener('keydown', function(event) {
if (event.altKey && event.shiftKey && event.key === 'E') {
window.location.href = `${protocol}//${domain}?title=${h1.innerText}&action=edit`;
}
});
```
Note that I used [template strings](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) to put the variables values inside a single string. Note that the delimiter is the character <code>`</code> - you're using double quotes, so `"domain?title=h1&action=edit"` doesn't put the value of the `domain` variable in the string (instead, it puts the word "domain", which is not what you want).
But you could also use old-style concatenation:
```javascript
window.location.href = protocol + '//' + domain + '?title='+ h1.innerText + '&action=edit';
```

You're getting close, just need a few adjustments.
Instead of using the `hostname` property, I prefer to use `host`, because it also includes the port (in case the URL has one) - check the [documentation](https://developer.mozilla.org/en-US/docs/Web/API/Location/host) for more info.
You should also get the `protocol` (which can be `http`, `https`, etc), to build the full URL. Without it, you might not get what you want: suppose the current page is `https://software.codidact.com/posts/286256`. If I run this code:
```javascript
let domain = window.location.host;
window.location.href = domain + '?abc=1';
```
The result will be the URL `https://software.codidact.com/posts/software.codidact.com?abc=1`. Only by including the protocol at the beggining (before the `domain`), I get the correct URL (`https://software.codidact.com/?abc=1`).
To set the URL you should use `=`, not `===` (the difference is explained [here](https://software.codidact.com/posts/282893)).
Not sure how you're using the `h1` element, I guess you wanted to get its text? I included an example below, that gets the `innerText` property, which contains whatever text is inside the `h1` tag.
And finally, when the `shiftKey` property is set, the corresponding key will be uppercased, so instead of checking for `e`, you actually should check for `E`.
The final code:
```javascript
let domain = window.location.host;
let protocol = window.location.protocol;
let h1 = document.getElementsByTagName("h1");
window.addEventListener('keydown', function(event) {
if (event.altKey && event.shiftKey && event.key === 'E') {
window.location.href = `${protocol}//${domain}?title=${h1.innerText}&action=edit`;
}
});
```
Note that I used [template strings](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) to put the variables values inside a single string. Note that the delimiter is the character <code>`</code> - you're using double quotes, so `"domain?title=h1&action=edit"` doesn't put the value of the `domain` variable in the string (instead, it puts the word "domain", which is not what you want).
But you could also use old-style concatenation:
```javascript
window.location.href = protocol + '//' + domain + '?title='+ h1.innerText + '&action=edit';
```

Communities

Review Suggested Edit