Welcome to Software Development on Codidact!
Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.
Comments on Should I post a link to the Github repo for code reviews?
Parent
Should I post a link to the Github repo for code reviews?
Hello. Total noob here and noob to this site. I've written a non-trivial program in Python. Code review didn't take the whole thing (400+ lines of code). Should I post a link to my Github repo or is that not appropriate?
Post
Welcome!
It's best if the code being reviewed is here on the site, for ease of reference and defense against link rot. That sounds like a sizable program; are there key parts you'd like review on, as opposed to the whole thing? You could include the GitHub link for anybody who wants to run it as part of the review, but most of our code reviews have focused on smaller pieces. The various utility methods, accessors, etc probably aren't the interesting part, right? Also, if you focus on the most important parts, you're more likely to get good feedback from reviewers, as you'll make it easy for them to skip the routine stuff and focus on the meat.
0 comment threads