Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Post History

66%
+2 −0
Q&A How to enable or disable a bunch of reactive form controls?

Actually, TypeScript is perfectly able to type check the code you posted. Here's what the compiler thinks: const functionName = disable ? "disable" : "enable"; // inferred type: "disable" | "enabl...

posted 3y ago by meriton‭

Answer
#1: Initial revision by user avatar meriton‭ · 2021-04-01T16:44:07Z (about 3 years ago)
Actually, TypeScript is perfectly able to type check the code you posted. Here's what the compiler thinks:

    const functionName = disable ? "disable" : "enable"; 
    // inferred type: "disable" | "enable";
    this.form.get("foo")[functionName];
    // inferred type:
    //    FormControl["disable" | "enable"]()
    // = (FormControl["disable"] | FormControl["enable"])()
    // = (() => void)() | (() => void)()
    // = void

[Try it in the playground](https://www.typescriptlang.org/play?#code/PTAEGcHsFsFMIBYEtrgpUB3eATSA7AcgBdQEBDAN3mIxQAdIAnU8-AcwFcAbcpgKADGvcGgBizaAGECxJpG6gA3v1ChY+cgCNusABQBKZQF9VoHEnDbdhk-1NCR4ycrPtYxPZrgAuCHKQOIxU1NSYPTiZ8UHxYTFAJJmlZeW5DAG4zUwdhclFQAE1ISJloRlj8UhDQADMXAF4YuITJDP4zCysdWFLyjWJwPU7rWD8tSAVYNmCzNUECcFIaznxBYiQCADlyOFBG4e7QAH5QACID3VPQP1ONEdP00FnQEFBAmtgmcJxQYgBPeijM4XWBXAA+Zzu3Qez2IyHAADo6kkEe5PKc6pBTgYANrLVbrLY7WAAXTaoReYHen2+vwBo2er1CiWSlVSOPOlnuoAht000LJBkZYEaehZMjZCg5INOJJ5LSSErkUr59xJBkMwr2oD0tnqAD5QJRIEgcBqjBDdUYDUaTWbNRTXo1jaasvYgA)!

If you introduce a typo, you'll get nice error message:

    const functionName = disable ? "disabe" : "enable"; 
    this.form.get("foo")[functionName]();
    // error: Property 'disabe' does not exist on type 'FormControl'. Did you mean 'disable'?

Likewise if you mess up the call signature:

    this.form.get("foo")[functionName](3);
    // error: Expected 0 arguments, but got 1

So I'd say that your code is fine as is. If you are concerned about it's readability, you could move the conditional into a loop:

    for (const fieldName of ['foo', 'bar', 'baz']) {
      const control = this.form.get(fieldName);
      if (disable) {
        control.disable();
      } else {
        control.enable();
      }
    }

but whether this is an improvement is debatable.

Also note that if you just want to disable / enable all controls in a `FormGroup` or `Form`, you can simply disable / enable that `FormGroup` or `Form`, and it will propagate the signal to its children.