Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Post History

71%
+3 −0
Q&A Why static code analyzers such as SonarQube indicate a high code complexity for switch statements?

During a presentation of a pipeline configuration, a colleague showed a SonarQube integration and one of its reports. A warning was caused by overrunning the max value for the code complexity thres...

2 answers  ·  posted 3y ago by Alexei‭  ·  last activity 3y ago by Derek Elkins‭

#4: Post edited by user avatar Alexei‭ · 2022-02-05T15:46:41Z (almost 3 years ago)
minor fixes
  • During a presentation of a pipeline configuration, a colleague showed a SonarQube integration and of its reports. One warning was related by overrunning the max value for the code complexity in a function containing a fairly large switch statement.
  • Why are switch statements considered too complex and what to do about them?
  • The problematic code was similar to the one below, but containing about double of the case statements:
  • ```c#
  • enum FooStasus
  • {
  • ToBeStarted = 1,
  • Starting = 2,
  • OnGoing = 3,
  • OnHold = 4,
  • Stopped = 5
  • }
  • private static double GetWeight(FooStasus status)
  • {
  • switch (status)
  • {
  • case FooStasus.ToBeStarted:
  • case FooStasus.Starting: return 1.0;
  • case FooStasus.OnGoing: return 2.0;
  • case FooStasus.OnHold: return 0.2;
  • case FooStasus.Stopped: return 0;
  • default: return 0.5;
  • }
  • }
  • ```
  • []()
  • During a presentation of a pipeline configuration, a colleague showed a SonarQube integration and one of its reports. A warning was caused by overrunning the max value for the code complexity threshold in a function containing a fairly large switch statement.
  • Why are switch statements considered too complex and what to do about them?
  • The problematic code was similar to the one below, but containing about double of the case statements:
  • ```c#
  • enum FooStasus
  • {
  • ToBeStarted = 1,
  • Starting = 2,
  • OnGoing = 3,
  • OnHold = 4,
  • Stopped = 5
  • }
  • private static double GetWeight(FooStasus status)
  • {
  • switch (status)
  • {
  • case FooStasus.ToBeStarted:
  • case FooStasus.Starting: return 1.0;
  • case FooStasus.OnGoing: return 2.0;
  • case FooStasus.OnHold: return 0.2;
  • case FooStasus.Stopped: return 0;
  • default: return 0.5;
  • }
  • }
  • ```
  • []()
#3: Post edited by user avatar Alexei‭ · 2022-02-05T15:42:18Z (almost 3 years ago)
added language tag
#2: Post edited by user avatar Alexei‭ · 2022-02-05T15:39:41Z (almost 3 years ago)
added relevant code
  • During a presentation of a pipeline configuration, a colleague showed a SonarQube integration and of its reports. One warning was related by overrunning the max value for the code complexity in a function containing a fairly large switch statement.
  • Why are switch statements considered too complex and what to do about them?
  • During a presentation of a pipeline configuration, a colleague showed a SonarQube integration and of its reports. One warning was related by overrunning the max value for the code complexity in a function containing a fairly large switch statement.
  • Why are switch statements considered too complex and what to do about them?
  • The problematic code was similar to the one below, but containing about double of the case statements:
  • ```c#
  • enum FooStasus
  • {
  • ToBeStarted = 1,
  • Starting = 2,
  • OnGoing = 3,
  • OnHold = 4,
  • Stopped = 5
  • }
  • private static double GetWeight(FooStasus status)
  • {
  • switch (status)
  • {
  • case FooStasus.ToBeStarted:
  • case FooStasus.Starting: return 1.0;
  • case FooStasus.OnGoing: return 2.0;
  • case FooStasus.OnHold: return 0.2;
  • case FooStasus.Stopped: return 0;
  • default: return 0.5;
  • }
  • }
  • ```
  • []()
#1: Initial revision by user avatar Alexei‭ · 2022-02-05T15:38:05Z (almost 3 years ago)
Why static code analyzers such as SonarQube indicate a high code complexity for switch statements?
During a presentation of a pipeline configuration, a colleague showed a SonarQube integration and of its reports. One warning was related by overrunning the max value for the code complexity in a function containing a fairly large switch statement.

Why are switch statements considered too complex and what to do about them?