Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Post History

72%

+6 −1

Q&A How to unittest method that involves contacting remote servers?

Let's say I have this class: class myService { private boolean foo(T arg) { return arg == 42; } public Response bar(U arg) { if(foo(U.field)) { return Response.st...

1 answer · posted 3y ago by klutt‭ · last activity 3y ago by meriton‭

Question java unit-testing junit

#2: Post edited by

klutt‭ · 2022-02-22T11:03:48Z (almost 3 years ago)

Copy Link

Raw

Markdown

Let's say I have this class:
class myService {
private boolean foo(T arg) { return arg == 42; }
public Response bar(U arg) {
if(foo(U.field)) {
return Response.status(Response.Status.BAD_REQUEST).build();
}
// Code that contacts a remote server
}
}
I want to unittest this with Junit. But there are some problems. I'm actually mainly interested in testing `foo()`, but that one is private. I could make it public, but I really don't want to do that just so that the test class can access it.
It works fine to test test cases that should fail, which in this case means that `foo` returns true. But in the case that `foo` returns false, we will reach the code that contacts remote servers, and that's not desirable.
How should I refactor this so that I can test `foo` via `bar` regardless if `foo` returns true or false?

Let's say I have this class:
class myService {
private boolean foo(T arg) { return arg == 42; }
public Response bar(U arg) {
if(foo(U.field)) {
return Response.status(Response.Status.BAD_REQUEST).build();
}
// Code that contacts a remote server
}
}
I want to unittest this with Junit. But there are some problems. I'm actually mainly interested in testing `foo()`, but that one is private. I could make it public, but I really don't want to do that just so that the test class can access it. I could also write a wrapper around `bar()` but again, it feels weird to modify the API for this purpose.
It works fine to test test cases that should fail, which in this case means that `foo` returns true. But in the case that `foo` returns false, we will reach the code that contacts remote servers, and that's not desirable.
How should I refactor this so that I can test `foo` via `bar` regardless if `foo` returns true or false?

#1: Initial revision by

klutt‭ · 2022-02-22T10:58:30Z (almost 3 years ago)

Copy Link

Raw

Markdown

How to unittest method that involves contacting remote servers?

Let's say I have this class:

    class myService {
        private boolean foo(T arg) { return arg == 42; }

        public Response bar(U arg) {
            if(foo(U.field)) {
                return Response.status(Response.Status.BAD_REQUEST).build();
            }

            // Code that contacts a remote server
        }
    }

I want to unittest this with Junit. But there are some problems. I'm actually mainly interested in testing `foo()`, but that one is private. I could make it public, but I really don't want to do that just so that the test class can access it. 

It works fine to test test cases that should fail, which in this case means that `foo` returns true. But in the case that `foo` returns false, we will reach the code that contacts remote servers, and that's not desirable. 

How should I refactor this so that I can test `foo` via `bar` regardless if `foo` returns true or false?

java unit-testing junit

Communities

Post History