Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

How to define an object with different subclasses in an if-statement?

+8
−0

Note: I asked this question on TopAnswers a couple weeks ago, but didn't get any response, so I figured I'd ask it here.


I am currently learning C++. I have a parent class (Vehicle) and two subclasses (Car and Boat). I am wondering how to create an object that will either be Car or Boat, depending on what the user specifies.

Below is my best attempt. It compiles and runs, but doesn't do what I want. It is supposed to make *vh a Car or Boat, but *vh always remains a Vehicle.

#include <iostream>

using namespace std;

class Vehicle
{
	public:
		void print(void)
		{
			cout<<"this is a vehicle\n";
		}
};

class Car: public Vehicle
{
	public:
		void print(void)
		{
			cout<<"this is a car\n";
		}
};

class Boat: public Vehicle
{
	public:
		void print(void)
		{
			cout<<"this is a boat\n";
		}
};

int main()
{
	Vehicle *vh = new Vehicle();
	Car *cr = new Car();
	Boat *bt = new Boat();

	int x;
	cout<<"type 0 for car and 1 for boat: ";
	cin>>x;

	if(x==0)
	{
		cout<<"you chose car\n";
		vh = cr;
	}
	else if(x==1)
	{
		cout<<"you chose boat\n";
		vh = bt;
	}
	vh->print();
}
History
Why does this post require attention from curators or moderators?
You might want to add some details to your flag.
Why should this post be closed?

2 comment threads

Suggestion: Operator Overloading (2 comments)
Completely unrelated, but aren't you leaking memory (1 comment)

1 answer

+10
−0

What's going on is that the compiler is deciding on what function to call at compile time rather than runtime. Since the type of vh is Vehicle *, it is essentially creating this call:

vh->Vehicle::print();

There are a couple of different solutions to this, but the simplest is probably just to make the function virtual. This says that the function should be determined at runtime instead. (This is usually accomplished through virtual tables.)

class Vehicle
{
public:
	virtual void print(void)
	{
		std::cout << "this is a vehicle\n";
	}
};

class Car: public Vehicle
{
public:
	void print(void) override
	{
		std::cout << "this is a car\n";
	}
};

class Boat: public Vehicle
{
public:
	void print(void) override
	{
		std::cout << "this is a boat\n";
	}
};
History
Why does this post require attention from curators or moderators?
You might want to add some details to your flag.

0 comment threads

Sign up to answer this question »