Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Post History

66%
+2 −0
Q&A PHP code is not excluding the watched videos.

Does the watched_videos column contain unique_id's? Are these numeric or string IDs? (If they are string ID's you shouldn't quote them below!) Also, why not use the $exclude_list you already made?...

posted 11mo ago by dagelf‭

Answer
#1: Initial revision by user avatar dagelf‭ · 2023-04-23T21:40:27Z (11 months ago)
Does the `watched_videos` column contain `unique_id`'s? Are these numeric or string IDs? (If they are string ID's you shouldn't quote them below!)

Also, why not use the `$exclude_list` you already made? Did you print the queries and tried them manually, and do they return what you think they should? 

Also, your SQL will be invalid if the `watched_videos` array is empty.

    // Generate a comma-separated list of unique_id values to exclude
    $exclude_list = "";
    if (!empty($watched_videos)) {
        $exclude_list = "NOT IN ('" . implode("', '", $watched_videos) .      "')";
    }

And your SQL lines:

    // Select two random videos from the "less_videos" table, excluding watched videos
    $sql_less = "SELECT video_id, description, points FROM less_videos WHERE unique_id $exclude_list ORDER BY RAND() LIMIT 2";
    $result_less = mysqli_query($conn, $sql_less);

    // Select ten random videos from the "more_videos" table, excluding watched videos
    $sql_more = "SELECT video_id, description, points FROM more_videos WHERE unique_id $exclude_list ORDER BY RAND() LIMIT 10";
    $result_more = mysqli_query($conn, $sql_more);

It's also a good idea to sanitize anything that's going into another SQL query, no matter where it comes from.