Welcome to Software Development on Codidact!
Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.
Post History
if(typeof(var) !== 'undefined' || typeof(var) !== null || var !== ''){}else{} is a wild thing to write for anything other than a variable that takes either undefined, null, or a string as possib...
Answer
#1: Initial revision
``` if(typeof(var) !== 'undefined' || typeof(var) !== null || var !== ''){}else{} ``` is a wild thing to write for anything other than a variable that takes either undefined, null, or a string as possible values. If you expect `someVar` to be a boolean, I don't know who would tell you that `if (someVar) { ... }` is incorrect. If you expect `someVar` to be a boolean or null or undefined, or you expect it to be some other non-boolean type, then there's an argument for some sort of explicit coverage. People reading `if (someVar) { ... }` may expect `someVar` to be a boolean, even though JavaScript allows it to be other things. So if you want to express that `someVar` is a string, it's arguably better to write `if (someVar !== '') { ... }` then `if (someVar) { ... }` in order to make that expectation clear, even though they do the same thing. Similarly, if `someVar` may be a boolean or null, writing `if (someVar === false || someVar === null) { ... }` is clearer than `if (!someVar) { ... }`. These are choices that will affect how some other people will read your code, and not what the machine will do. Programming is an act of communication and not just the puzzle of getting the machine to do the thing you want. Even the code you never share with others might be read by you five years later, and you'll be grateful then for the work you do now to save that you some time.