Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Comments on connect with SLOT/SIGNAL: QPushButton clicked signal not received by main window

Parent

connect with SLOT/SIGNAL: QPushButton clicked signal not received by main window

+3
−0

I added a QPushButton to my ui file named pushButton, and manually connected it using connect.

  • There are no errors or warnings emitted at any point in the compilation stage
  • The button does show up on the UI.
  • When I click on the button, nothing happens.

MainWindow.cpp:

#include "mainwindow.h"
#include "ui_mainwindow.h"
#include <QMessageBox>

MainWindow::MainWindow(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);

    connect(ui->pushButton, SIGNAL(clicked()), this, SLOT(pushButton_Clicked));
}

MainWindow::~MainWindow()
{
    delete ui;
}

void MainWindow::pushButton_Clicked()
{
    QMessageBox::information(nullptr, tr("Status"), tr("You clicked the button!"));
}

MainWindow.h

#ifndef MAINWINDOW_H
#define MAINWINDOW_H

#include <QMainWindow>

namespace Ui {
class MainWindow;
}

class MainWindow : public QMainWindow
{
    Q_OBJECT

public:
    explicit MainWindow(QWidget *parent = 0);
    ~MainWindow();

private:
    Ui::MainWindow *ui;

private slots:
    void pushButton_Clicked();
};

#endif // MAINWINDOW_H

What do I need to do to make MainWindow::pushButton_Clicked() get called when the button is clicked?

History
Why does this post require attention from curators or moderators?
You might want to add some details to your flag.
Why should this post be closed?

0 comment threads

Post
+4
−0

Qt's SLOT macro is very specific in what it accepts.

When specifying a slot in the connect function, it's required to put parenthesis, so the correct code would be:

connect(ui->pushButton, SIGNAL(clicked()), this, SLOT(pushButton_Clicked()));

With this syntax, the button clicked() signal will be received by MainWindow.

Some background information

When you use the SLOT() macro, you aren't passing in a function pointer, it actually stringizes what you pass in behind the scenes.

So you could actually do something like this, and it would still be accepted.:

connect(ui->pushButton, SIGNAL(clicked()), this, SLOT(gibberish));

Unfortunately there are no errors or warnings to help find typos in usages of the SLOT macro, be very careful with this macro.

Alternatives

It's possible to use function pointers instead of using the SIGNAL/SLOT macros.

connect(ui->pushButton, &QPushButton::clicked, this, &MainWindow::pushButton_Clicked);

For overloaded functions, it's necessary to explicitly specify the type of function pointer, (auto is no help).

void (QComboBox::*comboBox_IndexChanged)(int) = &QComboBox::currentIndexChanged;

QObject::connect(itemComboBox, comboBox_IndexChanged, this, &MainWindow::OnCellComboBoxChanged, Qt::AutoConnection);

// note: 
// QObject::connect(itemComboBox, &QComboBox::currentIndexChanged(int), this, &MainWindow::OnCellComboBoxChanged(int));
// does NOT work. Unfortunately you cannot specify an overloaded method like this.

I think there are some other methods too, but these are the best options I was able to find in Qt 5.7.0

History
Why does this post require attention from curators or moderators?
You might want to add some details to your flag.

1 comment thread

General comments (2 comments)
General comments
dmckee‭ wrote about 4 years ago

I'd go further than calling the new syntax an "alternative". I wouldn't use the SIGNAL and SLOT macros in new code. Indeed, unless I was still trying to support Qt4 I wouldn't write new instances of the macros even in a legacy code base.

jrh‭ wrote about 4 years ago · edited about 4 years ago

@dmckee, yes, I am inclined to agree; I'll never use these macros again. Thanks for the tip that this is something carried over from Qt4, I did not know that. Though, does that mean that the function pointer syntax is "new"? Function pointers are built into the language, as somebody who's only used Qt4 it seems like if anything the SLOT macros would have come later, but perhaps Qt4 needed extra information? Interesting.