Welcome to Software Development on Codidact!
Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.
Comments on Question regarding an error message in my compiler to do with my code on linked list.
Parent
Question regarding an error message in my compiler to do with my code on linked list.
Can anyone help me, I'm currently learning pointers, this is the code I wrote to try and insert a node at the beginning of the list. However at the part where I included the comment of "error at this line" basically my compiler gave me the error of "In function Insert: Node undeclared". Why is it so?
#include<stdlib.h>
#include<stdio.h>
struct Node{
int data;
struct Node* next;
};
struct Node* head;
void Insert(int x){
Node* temp = (Node*)malloc(sizeof(struct Node)); //error at this line
temp->data = x;
temp->next = head;
head = temp;
if(head != NULL)
temp->next = head;
head = temp;
}
void Print(){
struct Node* temp = head;
printf("List is: ");
while(temp != NULL){
printf("%d", temp->data);
temp = temp->next;
}
printf("\n");
}
int main(){
head = NULL; //empty list
printf("How many numbers?\n");
int n, i;
scanf("%d", &n);
for(int i=0; i < n; i++){
printf("Enter the number\n");
scanf("%d", &x);
Insert(x);
Print();
}
}
First edit:
Update: My program runs, lets me enter the amount of numbers I want, as well as the numbers, however it prints out only the latest number I entered. What could possibly be the problem? Thanks.
#include<stdlib.h>
#include<stdio.h>
struct Node{
int data;
struct Node* next;
};
struct Node* head;
void Insert(int x){
struct Node* temp = (struct Node*)malloc(sizeof(struct Node));
temp->data = x;
temp->next = head;
head = temp;
if(head != NULL)
temp->next = head;
head = temp;
temp->next = NULL;
}
void Print(){
struct Node* temp = head;
printf("List is: ");
while(temp != NULL){
printf("%d", temp->data);
temp = temp->next;
}
printf("\n");
}
int main(){
head = NULL; //empty list
printf("How many numbers?\n");
int n, i;
scanf("%d", &n);
for(int i=0; i < n; i++){
printf("Enter the number\n");
scanf("%d", &x);
Insert(x);
Print();
}
}
Post
To use the identifier Node without typing struct Node, you must use a typedef:
typedef struct Node{ // this here is a stuct tag
int data;
struct Node* next; // this has to be struct Node, refers to the above tag
}Node; // but from this line and onward we can use Node
typedef and struct tags reside in different namespaces, why we can use the same identifier Node twice for seemingly unrelated purposes. Since a linked list node needs to be self-referring, we have to use the struct tag so the compiler knows what to do until the struct type definition is completed at the final ;
Another equivalent alternative would be a forward declaration:
typedef struct Node Node; // forward declaration inside a typedef
struct Node{ // struct tag to associate this with the above typedef
int data;
Node* next; // now the compiler knows what Node is before the struct is complete
};
Note that C++ is different here.
1 comment thread
1 comment thread