Welcome to Software Development on Codidact!
Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.
Comments on Reaction comment doesn't appear if previous comment for retracted reaction was deleted
Parent
Reaction comment doesn't appear if previous comment for retracted reaction was deleted
On this answer I just reacted with “works for me” with comment, but then retracted it because of what finally turned out to be a mistake on my end, and deleted also the comment (and thus the comment thread). After figuring out my mistake, I gave again the “works for me” reaction with comment, but this time, the comment didn't appear (the reaction did).
This is clearly a bug, as the new comment should have appeared.
Post
I wrote this in a comment on the GitHub issue and would be interested in input:
I can think of two fixes, both in the reaction-handling code:
- Check for an existing thread (as it does now) and then, if it's deleted, undelete it. Problem: this can resurrect something that a moderator decided to delete (as the easiest way to clean up a mess), which could be a problem. We can mitigate that in various ways, or we can...
- Check for an existing thread (as now), and if it's deleted, break the association between that thread and the reaction and then create a new reaction thread as if that other one didn't exist. If the other one gets undeleted, it's just history, not the active thread. Breaking the association could include renaming it to make that clear. (I don't know how the code works; maybe renaming it is enough to break the association?)
1 comment thread