Welcome to Software Development on Codidact!
Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.
Comments on Scheme for cross-platform warning control?
Parent
Scheme for cross-platform warning control?
tl;dr I'd like to learn a compact, cross-compiler way of selectively suppressing compiler warnings.
Consider the case where you really mean to make an exact floating-point comparison using ==, or the case where you capture a return value that you don't use in production but want to assert on in debug.
If you are running your compiler with a highly level of feedback you're going to get a warnings from the first all the time and from the second when performing a release build.
Now, most compilers have a way to annotate a symbol to let the compiler know you're aware of the situation (for instance __attribute__((unused)) in gcc), and various pre-processor pragmas to adjust the compilation envrionment. But we have three compilers to worry about (gcc and msvc for actually building the code on different target platforms and clang as a linter on both).
In some places we actually have painfully heavy and intrusive pre-processor constructs like:
#if defined(_MSC_VER)
#pragma warnings(push)
#pramga warnings(disable : 123456)
#elif defined(__clang__)
#pragma clang diagnostic push
#pramga clang diagnostic ignored "-Wluggage-combination"
#elif defined(__GNUC__)
#pragma GCC diagnostic push
#pramga GCC diagnostic ignored "-Wcode-for-my-luggage"
#endif
// Offending line(s) of code
#if defined(_MSC_VER)
#pragma warnings(pop)
#elif defined(__clang__)
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif
Which, though ugly as sin, works and doesn't cause too much nausea if it occurs once in a low-level module that you don't touch often.
But I feel that it should be easier and neater.
Anyone have a working solution?
Post
Since C++11 the standard mandates the _Pragma operator which is intended for use inside macros.
With this you can improve the situation by wrapping all this compiler switching into a central macro definition (MSVC is untested!):
// see https://stackoverflow.com/a/45783809
#define DO_PRAGMA_(x) _Pragma (#x)
#define DO_PRAGMA(x) DO_PRAGMA_(x)
#define PUSH_WARNING_STATE DO_PRAGMA(warnings(push)) \
DO_PRAGMA(clang diagnostic push) \
DO_PRAGMA(GCC diagnostic push)
#define POP_WARNING_STATE DO_PRAGMA(warnings(pop)) \
DO_PRAGMA(clang diagnostic pop) \
DO_PRAGMA(GCC diagnostic pop)
#define DISABLE_WARNING(WARNING_NAME) DO_PRAGMA(warnings(disable : WARNING_NAME##_MSC) ) \
DO_PRAGMA(clang diagnostic ignored WARNING_NAME##_CLANG) \
DO_PRAGMA(GCC diagnostic ignored WARNING_NAME##_GCC)
Which can be used like:
// find some custom central naming for your warnings
#define WARN_UNINITIALIZED_CLANG "-Wuninitialized"
#define WARN_UNINITIALIZED_GCC "-Wuninitialized"
int main(int argc, char **argv) {
float a = 0, b;
PUSH_WARNING_STATE
DISABLE_WARNING(WARN_UNINITIALIZED);
if(a != b) {
POP_WARNING_STATE
return a == b;
}
}
Compiling gives only the second error, as intended:
$ g++ -Wall -pedantic test.cpp
test.cpp: In function 'int main(int, char**)':
test.cpp:39:12: warning: 'b' may be used uninitialized in this function [-Wmaybe-uninitialized]
39 | return a == b;
| ~~^~~~
Limitations:
- problem with warnings that can only be disabled on some platforms (-> pragma might trigger a warning)
1 comment thread