Communities

Writing
Writing
Codidact Meta
Codidact Meta
The Great Outdoors
The Great Outdoors
Photography & Video
Photography & Video
Scientific Speculation
Scientific Speculation
Cooking
Cooking
Electrical Engineering
Electrical Engineering
Judaism
Judaism
Languages & Linguistics
Languages & Linguistics
Software Development
Software Development
Mathematics
Mathematics
Christianity
Christianity
Code Golf
Code Golf
Music
Music
Physics
Physics
Linux Systems
Linux Systems
Power Users
Power Users
Tabletop RPGs
Tabletop RPGs
Community Proposals
Community Proposals
tag:snake search within a tag
answers:0 unanswered questions
user:xxxx search by author id
score:0.5 posts with 0.5+ score
"snake oil" exact phrase
votes:4 posts with 4+ votes
created:<1w created < 1 week ago
post_type:xxxx type of post
Search help
Notifications
Mark all as read See all your notifications »
Q&A

Welcome to Software Development on Codidact!

Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.

Comments on Why does this code that uses a pointer-to-pointer-to-int segfault?

Post

Why does this code that uses a pointer-to-pointer-to-int segfault?

+1
−3

Hello folks, can someone resolve this seg fault with me please, i can't find the error where it occur. Thank you.

#include <stdlib.h>
 #include <stdio.h>
 int ft_ultimate_range(int **range, int min, int max)
 {
    int lentgh;
    int i;
    int mi;
    
    mi = min;
    lentgh = max - min;
    if (min >= max)
    {
        // *range = NULL;
        return (0);
    }
    *range = malloc(sizeof(int) * lentgh);
    if(!range)
    {
        return 0;
    }
    i = 0;
    while (min < max)
    {
        range[0][i] = mi;
        i++;
        mi++;
    }
    return (i);
}

int main()
 {
    int i = 0;
    int min = 5;
    int max = 19;
    int **range = 0;
    int ptr = ft_ultimate_range(range, min, max);`

    while(i < max - min)
    {
        printf("%d\n", ptr);
        i++;
    }
    return (0);
}
History
Why does this post require moderator attention?
You might want to add some details to your flag.
Why should this post be closed?

3 comment threads

Infinite loop (3 comments)
when i compile it i got no error, but when i run it using ./a.out i got : "segmentation fault ./a.ou... (1 comment)
What does the debugger tell you? (1 comment)
Infinite loop
hkotsubo‭ wrote almost 3 years ago · edited almost 3 years ago

while (min < max) - this is an infinite loop, because both min and max never change their values anywhere in the loop. Thus, i ends up accessing some position out of the array's bounds, which usually causes a segfault - I didn't test the code to see if there are more problems, but at a first look I could spot this one

M3dc0d‭ wrote almost 3 years ago

thank u, i i have solve the problem, yes it's an infinite loop, i did declare a variable mi and i did'nt use it in the loop, i used the min variable. Thank u

elgonzo‭ wrote almost 3 years ago · edited almost 3 years ago

There is also another logical problem with your program (unrelated to the segfault, though). Hint: Compare what you believe the code in the while(i < max - min) { ... } loop in your main function does with what it actually does in reality...