Welcome to Software Development on Codidact!
Will you help us build our independent community of developers helping developers? We're small and trying to grow. We welcome questions about all aspects of software development, from design to code to QA and more. Got questions? Got answers? Got code you'd like someone to review? Please join us.
Comments on Is omitting braces for single statements bad practice?
Parent
Is omitting braces for single statements bad practice?
Consider this code:
while(arr[index] != 0)
index++;
vs
while(arr[index] != 0) {
index++;
}
Personally, I prefer the first. The fact that the braces are not needed makes them -- unnecessary. :)
To me, it's just clutter that wastes a line. Or 2 if you're one of them that also want the opening brace on a new line. The line waste can be avoided though, if you do like this:
while(arr[index] != 0) index++;
I often do that, and I like the style. Partially because it makes those loops stand out from loops with braces.
One argument I've heard for always using braces is that if you want to add another statement, then you need to remember adding braces or you will have bugs that can be hard to find. For instance, this would be an endless loop:
while(arr[index] != 0)
println("No zero found");
index++;
While this is technically true that this mistake can be done, I find it a bit meh as an argument. If you're using an editor that autoindents the code, this mistake would be spotted immediately. And since using such an editor is something that you should do anyway, the point of this argument is a bit moot.
Plus, even though I have often coded without such an editor, I cannot remember ever doing that mistake. It feels like a mistake that one could do if you're used to Python. But adjusting coding standards of C, C++, Java and such to not confuse Python coders does not really seem like the right path to go.
Apart from this argument, I have not really seen anything else than the consistency argument. That always using the same style is consistent. Well it's true, but consistency is not ALWAYS good.
Have I missed something here? What do you say? Is omitting braces for single statements bad practice?
> While \[the Apple "goto fail bug"\] is pretty interesting, it's anecdotal evidence. I understand that it's still possi …
4y ago
Not using braces is considered bad practice by widely recognized industry coding standards (MISRA-C:2012 rule, 15.6, CER …
4y ago
Already good answers, but I can provide a slightly different perspective here: always use braces if there is a risk of g …
4y ago
I'm in the "Use the braces. Just use them every time" camp [^1]. As others have suggested you or your tooling will catch …
4y ago
Advantages of Mandatory Braces When in Rome, do as the Romans do. Since every popular coding standard for java manda …
4y ago
While there are already good answers, i want to give yet another reason to always use `{}`: Macros. Lets consider thi …
1y ago
Post
While there are already good answers, i want to give yet another reason to always use {}: Macros.
Lets consider this code:
#include <stdio.h>
#define FOO(n) puts(n[1]); puts(n[0]);
int main(int argc, char **argv)
{
if(argc>1)
FOO(argv);
}
You may expect that the code inside the macro FOO is only executed when argc>1, but no, some of the code is always executed. The code gets expanded to:
...
if(argc>1)
puts(n[1]); puts(n[0]);
....
Which is the same as:
...
if(argc>1)
puts(n[1]);
puts(n[0]);
....
Which probably wasn't the intention. While the macro FOO is written in a bad way (because it allows this error), this error could still have been prevented by using {} for the if.
2 comment threads